search

genkgo / ember-localforage-adapter

Offline usage for Ember Data, based on localstorage adapter, but now uses Mozilla's localforage as data source
Other
133 stars 26 forks source link

Create a branch for continuing support of version 1.13.x #47

Closed sebweaver closed 9 years ago

sebweaver commented 9 years ago

Since ED 2.0 (and future ELA 2.1) contains some breaking changes and unsupported deprecations, some users may be unable, or unwilling, to migrate.

That's why I think ELA 1.13 should be still maintained, at least for a while, and a branch should be created in order to continue creating PR on it.

For example, I've create a fix for #46 which is: https://github.com/genkgo/ember-localforage-adapter/compare/v1.13.1...sebweaver:issue-46 and I'd like to create the corresponding PR.

I would also want to add these this workaround into another PR, which could benefit to users of ELA 1.13 too.

What do you think?

frederikbosch commented 9 years ago

Agreed. We also did that when switching to Ember CLI Addon. Will take action after holidays (next Thursday).

frederikbosch commented 9 years ago

Done, see branch ember-113-compat.