genkgo / ember-localforage-adapter

Offline usage for Ember Data, based on localstorage adapter, but now uses Mozilla's localforage as data source

Other

133 stars 26 forks source link

Deprecation: _shouldSerializeHasMany #70

Closed d-schloss-mvg closed 6 years ago

d-schloss-mvg commented 7 years ago

With ember-data 2.12 the method _shouldSerializeHasMany has been deprecated and promoted to public API shouldSerializeHasMany

DEPRECATION: The private method _shouldSerializeHasMany has been promoted to the public API. Please remove the underscore to use the public shouldSerializeHasMany method. [deprecation id: ds.serializer.private-should-serialize-has-many]

frederikbosch commented 7 years ago

@d-schloss-mvg Could you create a PR for this?

d-schloss-mvg commented 7 years ago

I created a pull request, but obviously this works only for newer ember-data-versions where _shouldSerializeHasMany is already available without underscore.

71

d-schloss-mvg commented 7 years ago

Updated pull request #71 @frederikbosch

frederikbosch commented 7 years ago

Will have a look soon! Thanks @d-schloss-mvg

ghost commented 7 years ago

Any news on this?