search

genkgo / mail

Library to send e-mails over different transports and protocols (like SMTP and IMAP) using immutable messages and streams. Also includes SMTP server.
https://mail.readthedocs.io/
Other
402 stars 21 forks source link

fix tls negotation for RFC 821 servers #39

Closed frederikbosch closed 6 years ago

frederikbosch commented 6 years ago

When using a RFC 821 server, one cannot detect feature because they are not advertised with a HELO command. That 's why there is a EHLO command. That means that when negotiating STARTTLS one should not detect the feature but rather go for it anyhow.

frederikbosch commented 6 years ago

@GawainLynch Just extended the features that you added this week a little. Would you be willing to review?

GwendolenLynch commented 6 years ago

Of course. :+1:

frederikbosch commented 6 years ago

Hehe, yes, I saw that because of the coverage results.

frederikbosch commented 6 years ago

Thanks for the review.