genn-team / ml_genn

A library for deep learning with Spiking Neural Networks (SNN).
https://ml-genn.readthedocs.io
GNU Lesser General Public License v2.1
24 stars 7 forks source link

Tonic spike conversion incorrect if width != height #68

Closed neworderofjamie closed 10 months ago

neworderofjamie commented 1 year ago

Assuming shape provided by tonic is (width, height, channels), then the shape[1] here:

https://github.com/genn-team/ml_genn/blob/master/ml_genn/ml_genn/utils/data.py#L99 https://github.com/genn-team/ml_genn/blob/master/ml_genn/ml_genn/utils/data.py#L111

should be shape[0]. This was previously undetected because the only visual dataset I tried was DVS gesture which is 128x128 (and we downsampled to 32x32). No one need know how much sleep-deprived debugging this required...