search

genn-team / ml_genn

A library for deep learning with Spiking Neural Networks (SNN).
https://ml-genn.readthedocs.io
GNU Lesser General Public License v2.1
24 stars 7 forks source link

Fix width height confusion in tonic sensor_size #83

Closed tnowotny closed 11 months ago

tnowotny commented 11 months ago

Assuming that the tonic shape is width, height, channels, y needs to be multiplied with shape[0] (the width).

codecov-commenter commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (611cd50) 62.49% compared to head (db45a87) 62.49%.

Files Patch % Lines
ml_genn/ml_genn/utils/data.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #83 +/- ## ======================================= Coverage 62.49% 62.49% ======================================= Files 97 97 Lines 3775 3775 ======================================= Hits 2359 2359 Misses 1416 1416 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neworderofjamie commented 11 months ago

I can verify, based on https://github.com/neuromorphs/tonic/blob/develop/tonic/datasets/asl_dvs.py#L39 and https://github.com/neuromorphs/tonic/blob/develop/tonic/datasets/visual_place_recognition.py#L69 that shape[0] is indeed width