search

genn-team / pynn_genn

PyNN interface to GeNN
GNU General Public License v2.0
9 stars 3 forks source link

Check spike times for spike source array #61

Open chanokin opened 3 years ago

neworderofjamie commented 3 years ago

Why not just sort each array of spike times in SpikeSourceArray.get_extra_global_neuron_params?

chanokin commented 3 years ago

Why not just sort each array of spike times in SpikeSourceArray.get_extra_global_neuron_params?

The problem is that the test

https://github.com/genn-team/pynn_genn/blob/4415114beb7f37d4e6fe045e5a3fff4090dc75dd/test/system/scenarios/test_cell_types.py#L331-L336

expects the population to throw an exception if the order is wrong

neworderofjamie commented 3 years ago

I was just checking on the build machine and, this change has now caused https://github.com/genn-team/pynn_genn/blob/master/test/system/scenarios/test_procedural_api.py#L9 to fail. I can't quite see why tbh...

chanokin commented 3 years ago

I think test_procedural_api.py: ticket195() was failing due to this. I had forgotten to remove an incorrect version of this test from the 'use_pynn_array_test_utils' branch.