search

gennaro-tedesco / nvim-possession

📌 the no-nonsense session manager
MIT License
215 stars 7 forks source link

Telescope support #10

Closed SingularisArt closed 1 year ago

SingularisArt commented 1 year ago

I've fixed both of this silly mistakes.

gennaro-tedesco commented 1 year ago

Sorry for being unresponsive on this PR; this week I focussed on adding a few more features for autoload/autosave/autoswitch and post load hooks (as you can find in the latest releases). Once we reach some stable status I can revise this with more ease (I am still not sure if it is worth including the Telescope scope in here, but let us keep our options open :) )

carlosflorencio commented 1 year ago

Just to add, having Telescope support would be great. After using this fzf-lua version I prefer the Telescope UX in general.

gennaro-tedesco commented 1 year ago

Just to add, having Telescope support would be great. After using this fzf-lua version I prefer the Telescope UX in general.

Yes, definitely a valid point. I am thinking to refactor the code and separate the ui components so that we can ideally hook up many others too.

SingularisArt commented 1 year ago

I went ahead and created it in its own separate repo. Are we still going to be merging this pr in the future, if so, I can go ahead and update all the code since it's outdated after the last couple of commits @gennaro-tedesco did. EDIT: Here's the repo link.

gennaro-tedesco commented 1 year ago

Are we still going to be merging this pr in the future,

I would still like to see if it is possible to make it compatible, even if just for myself to understand what is required for Telescope (I just didn't have the time this week). Good idea however to extract it out to another repository if you want to continue independent development.

If you do not want to keep a fork around feel free to delete it, I have a local branch with this changes that I can look at :)

SingularisArt commented 1 year ago

Great! I'll also, later on (not this week, busy with school) see if I can bring my old changes up to date with all the new improvements that you made.

gennaro-tedesco commented 1 year ago

Relevant to this discussion: I started a branch ui where I am separating the ui component (at the moment fzf only) instead of defining it in the setup({...}) function: see here. The idea is to have the corresponding ui elements only load when invoked for the list() method instead than at initialisation (which should speed up the loading and also allow for some custom lazy loading on events if user wants). I am still experimenting to get things right.

Relevant because if so we could create the corresponding "telescope ui" in a separate module, with whichever telescope components only loading on demand as well, which should then save up on the whole plugin initialisation times if users don't want to use them. Likewise it would allow for even further extensibility, since then people could just add their own ui components from whichever other plugin or interface.

Conceptually it would more or less also address https://github.com/gennaro-tedesco/nvim-possession/issues/8

What do you think?