Closed gennaro-tedesco closed 1 year ago
We will have to wait for https://github.com/ibhagwan/fzf-lua/pull/640 before this will work.
Have you added your
LUAROCKS_API_KEY
to this repo's GitHub actions secrets?
Yes, all is set, I would just need to create a new tag after merging and the action should trigger and push to the luarocks account :)
We will have to wait for https://github.com/ibhagwan/fzf-lua/pull/640 before this will work.
Awesome, thank you very much for your help!
fzf-lua
is now on luarocks :tada:
So we can proceed with this PR.
I am manually testing the action by adding a worfklow_dispatch
event (so that the action can be triggered manually), however it fails with
This GitHub workflow is designed to be run on tagged releases only
from this comment I take it should not be the case?
...after a few fixes...uh-uh, look at this beauty!
Nice! :partying_face:
Some background information:
One thing you might want to consider: fzf-lua
is licensed under AGPL-3.0, which is a copyleft license (i.e. software that depends on it should be licensed under the same terms).
I don't think an MIT license is compatible with that.
Good afternoon @mrcjkb, we spoke on reddit few days ago! This is an example of a plugin that uses a dependency, thus fulfilling the scope of creating luarocks dependencies spec.
Since this is the first time I am using your GitHub action, would you mind going over the change to make sure I have not forgotten anything needed?