gennaro-tedesco / nvim-possession

📌 the no-nonsense session manager
MIT License
215 stars 7 forks source link

Support telescope #2

Closed SingularisArt closed 1 year ago

SingularisArt commented 1 year ago

Hello! I really want to start using sessions in neovim, but I've always seen the session plugins to be bloated with a bunch of features that I don't need, which is why I'm currently using yours. Do you think you could support telescope.nvim? Like, in the setup, you could specify what you want to use, like:

require("nvim-possession").setup({
  viewer = "telescope|fzf",
  ...
})
gennaro-tedesco commented 1 year ago

Do you think you could support telescope.nvim? Like, in the setup, you could specify what you want to use, like:

yes, this is planned for future releases. However, I am not able to estimate when exactly simply because - not using Telescope myself - I am not familiar with how they implement extensions and I would need some time to look into it and learn it. I will keep this issue open since other people asked for it already as well, and they can refer to this.

SingularisArt commented 1 year ago

I'll help you with that over the weekend, since I use telescope for pretty much everything.

gennaro-tedesco commented 1 year ago

That's great! Meanwhile I will start looking into it as well :)

tmpm697 commented 1 year ago

+1

SingularisArt commented 1 year ago

Alright. I've got the basics working. I'll create a PR tomorrow with a more refined way of doing things.

tmpm697 commented 1 year ago

@SingularisArt can you decouple it to a separate plugin instead of an PR to nvim-possession?

gennaro-tedesco commented 1 year ago

Alright. I've got the basics working. I'll create a PR tomorrow with a more refined way of doing things.

thank you very much @SingularisArt for your help, I am looking forward to the PR! Notice I might be a little slow in responding/reviewing the code within the week as I am at work (can only dedicate some time in the evenings) but I do see the notifications and all the rest, so please bear a little patience :)

can you decouple it to a separate plugin instead of an PR to nvim-possession?

I still think it can be of use to include it here unless the codebase for a Telescope extension is huge and changes too much.

SingularisArt commented 1 year ago

unfortunately, it does look like a huge chunk of the code will be rewritten. I think it'll be best if we put this in a separate repo, that's specifically for this telescope extension because we have to create the folder lua/telescope/_extension/*. IDK. What are your thoughts?

gennaro-tedesco commented 1 year ago

Hmm, I see, this is what I feared too. What part of the code must be re-written?

I am asking it because the original idea of this plugin is not to be a replacement of the other fully fledged plugins (especially Telescope) but rather to be a light extension that doesn't need much configuration or thinking. So whilst we are adding new features (see v0.0.2 for instance) and Telescope support would be awesome, I wouldn't want it to come at the price of complete refactoring/restructuring of the codebase.

SingularisArt commented 1 year ago

I've created a PR.