gennyble / textual

Text Rendering as a Service
Other
9 stars 1 forks source link

Fix pading and stripe width in Stripes #13

Closed gennyble closed 2 years ago

gennyble commented 2 years ago

These both used to be font size dependent, but we can no longer rely on having the font size when parsing these. Padding was 1/4th font size and stripe width was 1/8th.

We should get all the parameters for a text and parse them together.

gennyble commented 2 years ago

Actually I'm not sure this is the right solution. I've been thinking of setting these parameters as a kind of state, right? Why would setting the font size in the same text, but after you specify something like stripe width, go back and affect it? Padding is a whole other thing and we should probably just make it pixels.

gennyble commented 2 years ago

Fixed in 97cfe039f0be5da4a31395dc4f51c4ff927ee940