genodelabs / genode-allwinner

Allwinner SoC support for the Genode OS framework
Other
13 stars 10 forks source link

PinePhone: add camera driver component #10

Closed cnuke closed 1 year ago

cnuke commented 1 year ago

All referenced commits are needed for the pinephone_camera_drv and also depend on genodelabs/genode#4624 and genodelabs/genode#4625.

@nfeske please take a look, especially c3afc44 and 365779c. I still have to look into the yielding approach for switching the GPIO direction.

nfeske commented 1 year ago

I gave your branch a try. It works! :-)

Let me have a closer look at pin-driver's operation to reduce the initialization time...

nfeske commented 1 year ago

With the commits https://github.com/nfeske/genode/commit/15159af5a67e0499867842030c1c4483a769e882 and https://github.com/nfeske/genode-allwinner/commit/f84a19b0774b7a181b2e662330c67ff296d56ccd, the initialization time comes down to just a few seconds.

cnuke commented 1 year ago

Awesome, thanks for the adjustments!

cnuke commented 1 year ago

@nfeske commit 2759fee filters the pin sensing request. With it the touchscreen works and so does the pinephone_camera_drv (tested via camera_pinephone.run).

nfeske commented 1 year ago

Thank you @cnuke for your support. Commit https://github.com/cnuke/genode-allwinner/commit/2759fee049b5d4d4ed186044c8907e474bc320af indeed reconciles the drivers. Down the road, we will probably need a way to move these heuristics closer to the driver (or obtaining them from the device tree??) because the meanings of the pins ultimately depend on the board.

I appreciate the latest WIP state (especially the content added to sculpt/drivers/pinephone) on your branch, which I'll take as my starting point for today. ;-)

nfeske commented 1 year ago

Just a quick note that the integration worked out well.

cnuke commented 1 year ago

@nfeske please see the latest commts from issue#10-camera_pinephone_drv-2022-11-04.

nfeske commented 1 year ago

Thank you for the nicely rebased commit series, especially forth the adjustment of the add CSI settings commit. ;-)

Merged to staging.