genodelabs / genode-world

Collection of community-maintained components for Genode
Other
44 stars 46 forks source link

Build errors in drivers/input/imx53_tablet #346

Closed chelmuth closed 8 months ago

chelmuth commented 8 months ago

No urgent matter but annoying when testing make drivers on arm_v7a with repos/world enabled.

  Program drivers/input/imx53_tablet/imx53_tablet_input_drv                      
    COMPILE  main.o                                                              
.../src/drivers/input/imx53_tablet/main.cc: In constructor ‘Main::Main(Genode::Env&)’:
.../src/drivers/input/imx53_tablet/main.cc:48:34: error: ‘class Platform::Connection’ has no member named ‘revision’ 
   48 |                 switch (plat_drv.revision()) {                           
      |                                  ^~~~~~~~                                
.../src/drivers/input/imx53_tablet/main.cc:49:49: error: ‘SMD’ is not a member of ‘Platform::Session’
   49 |                         case Platform::Session::SMD:                     
      |                                                 ^~~                      
.../src/drivers/input/imx53_tablet/main.cc:50:42: error: ‘class Platform::Connection’ has no member named ‘enable’
   50 |                                 plat_drv.enable(Platform::Session::I2C_2);
      |                                          ^~~~~~                          
.../src/drivers/input/imx53_tablet/main.cc:50:68: error: ‘I2C_2’ is not a member of ‘Platform::Session’
   50 |                                 plat_drv.enable(Platform::Session::I2C_2);
      |                                                                    ^~~~~ 
.../src/drivers/input/imx53_tablet/main.cc:51:42: error: ‘class Platform::Connection’ has no member named ‘enable’
   51 |                                 plat_drv.enable(Platform::Session::I2C_3);
      |                                          ^~~~~~                          
.../src/drivers/input/imx53_tablet/main.cc:51:68: error: ‘I2C_3’ is not a member of ‘Platform::Session’
   51 |                                 plat_drv.enable(Platform::Session::I2C_3);
      |                                                                    ^~~~~ 
.../src/drivers/input/imx53_tablet/main.cc:52:42: error: ‘class Platform::Connection’ has no member named ‘enable’
   52 |                                 plat_drv.enable(Platform::Session::BUTTONS);
      |                                          ^~~~~~                          
.../src/drivers/input/imx53_tablet/main.cc:52:68: error: ‘BUTTONS’ is not a member of ‘Platform::Session’
   52 |                                 plat_drv.enable(Platform::Session::BUTTONS);
      |                                                                    ^~~~~~~
make[2]: *** [.../repos/base/mk/generic.mk:62: main.o] Error 1
chelmuth commented 8 months ago

Currently, I use the following patch.

+++ b/src/drivers/input/imx53_tablet/target.mk
@@ -1,5 +1,5 @@
 TARGET    = imx53_tablet_input_drv
-REQUIRES  = arm_v7
+REQUIRES  = arm_v7 BUGFIX
 SRC_CC    = main.cc
 LIBS      = base
 INC_DIR  += $(PRG_DIR)
skalk commented 8 months ago

@chelmuth I've prepared a commit that replaces the old platform API usage to the modern one. But I could not test it on real hardware. I hope that is sufficient.

chelmuth commented 8 months ago

That's great, thanks. Merged to staging.