genodelabs / genode-world

Collection of community-maintained components for Genode
Other
45 stars 47 forks source link

Extend SDL2 platorm support (resizing + textinput) #368

Closed cnuke closed 5 months ago

cnuke commented 6 months ago

Commit 745d4ae addresses the window resizing and also adds support for specifying the initial window size while 1757cda allows for handling 'SDL_TEXTINPUT` events (as is used for example by dhewm3's console).

I deliberately classify the commits as preliminary as they are probably not finished (working in all cases) but are working well enough and enhance the user experience (and should not break anything while doing so).

jschlatow commented 6 months ago

@cnuke I tested your commits with the updated libvnc (requires SDL2) and sdl_vnc. I made a few modifications to make it more robust and to suppress unknown keysym warnings that popped up at the VNC server. May you have a look whether 97fc0db breaks anything for dhewm3?

cnuke commented 6 months ago

@jschlatow thanks for the fixup commit that looks like a nice improvement indeed and works fine with dhewm3 :+1:.

chelmuth commented 6 months ago

Merged the fixup to staging.