search

genodelabs / genode

Genode OS Framework
https://genode.org/
Other
1.03k stars 249 forks source link

sculpt: log_kernel is unable to open kernel_log ROM on base-hw #5171

Closed jschlatow closed 1 month ago

jschlatow commented 1 month ago

While test-running #5066 on base-hw, I noticed that the ROM session request from log_kernel fails. If I'm not mistaken, the _kernellog ROM is only available on NOVA.

nfeske commented 1 month ago

You are right. We should better tweak log_kernel_start_node in sculpt.run to test for NOVA instead of checking the absence of certain boards.

jschlatow commented 1 month ago

Fixed by 7f378e8

nfeske commented 1 month ago

Thanks. I merged the fix with a minor whitespace adjustment as https://github.com/genodelabs/genode/commit/72a8ee95dfb81568aa7968482f2b2269ccf5903f.