genodelabs / genode

Genode OS Framework
https://genode.org/
Other
1.03k stars 249 forks source link

fb_sdl: filter key-repeat events #5172

Closed nfeske closed 1 month ago

nfeske commented 1 month ago

Since the move to SDL2 (#4993), fb_sdl delivers key repeat events as press events. The nitpicker GUI server then complaints about "Warning: suspicious double press of KEY_L". This behavior somewhat spoils the experience when test-driving Sculpt on base-linux. The effect can be easily reproduced via make run/bash KERNEL=linux BOARD=linux and holding a key.

On Genode, key-repeat events are handled by the event_filter, which emits repeated character events but no press. Hence, this issue should be fixed by preventing fb_sdl from reporting any repeated keys.