genodelabs / genode

Genode OS Framework
https://genode.org/
Other
1.06k stars 250 forks source link

usb: set control transfer timeout in libusb #5259

Closed skalk closed 1 month ago

skalk commented 3 months ago

Re-enable the setting of a timeout in the libusb backend implementation, otherwise certain devices (e.g. smartcard-reader) won't do any progress.

nfeske commented 3 months ago

Merged to staging.

chelmuth commented 2 months ago

I'm wondering if this is an intermediate step as you planned to apply a default timeout in the host driver and remove the timeout from the API.

skalk commented 2 months ago

@chelmuth that is true, but after looking at the different timeout values more closely again, I decided against the default timeout, as they can be quite different. Therefore, having the option within the API seemed necessary. Alternatively, we would need the ability to cancel a single request to track timeouts client-wise.

chelmuth commented 2 months ago

Thanks for the clarification - hence, timeouts in the API make much sense :-)