search

genodelabs / goa

Tool for streamlining the development of Genode applications
GNU Affero General Public License v3.0
19 stars 17 forks source link

Fix Goa for dynamic binaries #30

Closed ssumpf closed 1 year ago

ssumpf commented 1 year ago

Commit https://github.com/nfeske/goa/commit/60ef785cefedaa935a118addd34c7e2fe311f080 breaks qmake (ldlibs_exe missing) and Genode dynamic binaries (Component::construct gets garbage collected by ld, leading to broken binaries).

ssumpf commented 1 year ago

899c6c5 fixes qmake. d70baad and dfe434b fix dynamic binaries.

ssumpf commented 1 year ago

@trimpim: Could you try my qt5 branch (https://github.com/ssumpf/goa/tree/qt5) and check if it still works for your shared library use case?

nfeske commented 1 year ago

Thanks a lot for these fixes @ssumpf. I merged the three commits just now. So you may rebase your qt5 branch to the new head.

ssumpf commented 1 year ago

Thanks a lot for these fixes @ssumpf. I merged the three commits just now. So you may rebase your qt5 branch to the new head.

Ack & done.

trimpim commented 1 year ago

@ssumpf I have tested the current master, and my build of libraries still works.

ssumpf commented 1 year ago

Fixed in master.