search

genodelabs / goa

Tool for streamlining the development of Genode applications
GNU Affero General Public License v3.0
19 stars 18 forks source link

cargo: add static versioned stat() and fstat() symbols #61

Closed atopia closed 10 months ago

atopia commented 10 months ago

Due to ABI changes in FreeBSD 12, the libc crate used by rustc currently tries to link against versioned symbols of some library functions to preserve compatability with FreeBSD 11.

To make the standard library distributed with the x86_64-unknown-freebsd target work, statically link versioned stat() and fstat() symbols from the the compat-libc api package.

atopia commented 10 months ago

Thanks a lot for the compat-libc implementation @ssumpf! @nfeske I hope this implements your suggestion for a static library package correctly. @jschlatow please have a look if you find the Goa side of the implementation acceptable.

jschlatow commented 10 months ago

@atopia Looks reasonable from my perspective. Would you mind squashing your commits and changing the commit messages accordingly? I was first puzzled by the fork problem only to see that it was resolved by a later commit.

atopia commented 10 months ago

@jschlatow I have squashed the fixup commit but I would prefer to keep the other two commits separate: mostly to attribute authorship and also because @ssumpf's solution is interesting in it's own right and I think it would be good to keep it around for future reference.

chelmuth commented 10 months ago

@atopia your topic branch for genode contains two commits for this issue. What is your merging plan? In my opinion these commits do not affect any other Genode component and could be merged until tomorrow.