search

genodelabs / goa

Tool for streamlining the development of Genode applications
GNU Affero General Public License v3.0
20 stars 17 forks source link

Old xmllint versions do not separate --xpath matches by newline #89

Closed chelmuth closed 5 months ago

chelmuth commented 5 months ago

I experienced strange errors due to empty required_services arrays, which stemmed from an old xmllint/libxml2 version (2.9.4). Tests with version 2.9.10 succeeded.

Commit 6d5dd781490f0de698ab361e663e9060d1ce270b fixed my goa run but there might exists other places in goa that depend on the newlines.

jschlatow commented 5 months ago

I consulted the changelog: The newlines for xmllint --xpath have been added in version 2.9.9.

jschlatow commented 5 months ago

@chelmuth Unfortunately, your fix breaks #78. There seems to be no easy way to separate the matches in the output of versions prior to 2.9.9. Do we actually need support for those versions in Goa? An alternative would be to detect the version and warn the user instead. I think only Debian buster and Ubuntu 18.04 are affected.

chelmuth commented 5 months ago

If it's too much hassle, let's just drop support of libxml2 < 2.9.9