Labels for wopi-client pods

jglasbergen commented 4 months ago

Hi there,

I need to add labels to the wopi-client pods in order to make the network policies work. Can you explain where and how to do this in the values.yaml file?

genofire commented 4 months ago

please use the official helm-chart: https://github.com/CollaboraOnline/online/tree/master/kubernetes/helm/collabora-online

There I have added this feature recently: https://github.com/CollaboraOnline/online/pull/9240

genofire commented 4 months ago

You can consume it as helmrepo:

helm repo add collabora https://collaboraonline.github.io/online/
helm install collabora-online collabora/collabora-online

Or oci:

helm install collabora-online oci://ghcr.io/collaboraonline/charts/collabora-online --version 1.1.17

From:

jglasbergen commented 4 months ago

I added the podLabels and run the upgrade. But I don't see the label on the pods. I assume I did not put it i te right place, her is my values.yaml:

collabora:
  aliasgroups:
  - host: http://webapp:8000
  - host: https://test.casereditions.local

  extra_params: --o:ssl.enable=false --o:ssl.termination=true --o:num_prespawn_children=4

  server_name: test.casereditions.local

  existingSecret:
    enabled: false
    secretName: ""
    usernameKey: "username"
    passwordKey: "password"
  password: adminadmin
  username: admin
  env: []

autoscaling:
  minReplicas: 1

resources: {}

replicaCount: 1

dynamicConfig:

  ingress:
    hosts:
      - host: test.casereditions.local
        paths:
          - path: /
            pathType: ImplementationSpecific
    tls:
      hosts:
        - test.casereditions.local
      secretName: test-casereditions

podLabels:
  networking/data.egress: true
  networking/internet.egress: true
  networking/internet.ingress: true
  networking/service.egress: true
  networking/service.gress: true
  networking/webapp.egress: true
  networking/webapp.ingress: true

genofire commented 4 months ago

First could you put your yaml into a codeblock? https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks

Secound, do has switch to the correct Helm repo? Maybe you need to remove it first. Check it with helm repo list and helm repo remove collabora

jglasbergen commented 4 months ago

Thank you for the change. I was indeed not deploying the new version. Removing the repo and adding it again worked. The labels are added to the wopi-client pods.

genofire / collaboraonline-helm

Labels for wopi-client pods #2