Dockerize annotation tools

genome-nexus / annotation-tools

Tools developed for AACR GENIE to allow annotation of vcf and maf files from a number of centers and merging the results

MIT License

6 stars 15 forks source link

Dockerize annotation tools #49

Closed ruslan-forostianov closed 2 years ago

ruslan-forostianov commented 2 years ago

Add docker image for python aspects of the code

Notes:

The annotation_suite_wrapper.sh won't work since it requires annotation.jar and java dependencies. There is a separate docker image that combines all that together https://github.com/genome-nexus/genome-nexus/pull/633

ruslan-forostianov commented 2 years ago

@ao508 @sheridancbio @inodb @plukase @pieterlukasse Please have a look

ruslan-forostianov commented 2 years ago

@inodb Thanks for the review!

Indeed, annotation_suite_wrapper.sh script relies on annotation.jar to be in the folder next with other python scripts. I am not providing it with the docker file neither. I will add a clarification to the Dockerfile.

Ah, I've not been aware about the other PR. Thanks for pointing out.

inodb commented 2 years ago

I've updated the description of the PR a bit, feel free to change