many functions with Boolean return type always return true

[sheridancbio]

There are functions with a boolean return type (hypothetically to indicate success or failure of function) but which only return a true value. Either identify, detect, and report failures, or change these functions into return type "void". Failures can be reported either by the return type or by throwing an exception, but if the return type is never "false" then switch to void.

Also, if a function does return a true/false success value the calling code must check that value and report a problem if there was a failure, then take corrective action.

If exceptions are thrown, the appropriate "throws" clause must be put on the throwing function and the calling code should have an appropriate "try/catch". Do not use the "unchecked" RuntimeException classes unless they are actually appropriate to the case. The program should not "exception out" of execution unless it is a serious and hard to predict situation.

examples: PdbScriptsPipelinePreprocessing.java

• preprocessPDBsequences()
• preprocessPDBsequencesUpdate() PdbScriptsPipelineMakeSQL.java
• parse2sql
• parseblastresultsSmallMem
• generateSQLstatementsSingle
• genereateSQLstatementsSmallMem

[sheridancbio]

Examples are not complete .. scan the full code base for similar cases.

[juexinwang]

Done