genome-nexus / genome-nexus-annotation-pipeline

Library and tool for annotating MAF files using Genome Nexus Webserver API
MIT License
8 stars 25 forks source link

Add '-n' note column in maf and error message into error report #265

Closed leexgh closed 9 months ago

leexgh commented 9 months ago

Fix: https://github.com/genome-nexus/genome-nexus-annotation-pipeline/issues/255

rmadupuri commented 9 months ago

This is great! Thanks Xiang!

Should we also set the -n to be default? And is there a character limit to this column?

leexgh commented 9 months ago

@rmadupuri Not sure if we want to add -n by default, for most of the variants this column will be empty, only variants with altered genomic location will have value, so I'm not sure if it makes sense to do it for all variants. Have you ever seen a column reach the limit? Do you know what is the limit?

rmadupuri commented 9 months ago

@leexgh, should we add an extra check - if the value exists atleast for one variant in the maf, then we can prolly include the column? This is to be more transparent that we are updating the coordinates (I wonder how many people would explicitly define the -n and notice the changes otherwise). We can merge this PR and prolly implement this later if agreed.