search

genome-rcast / karkinos

Tumor genotyper, that detects SNV, absolute CNV and Tumor contents
Apache License 2.0
10 stars 2 forks source link

Fix/loh estimate #12

Closed xckitahara closed 3 years ago

xckitahara commented 4 years ago

There was a mistake in the conditional expression in the getNearistLine function.

The effect of this is to increase loh. As a result, it also affects the calculation of the copy number. However, this process is affected under the condition of high DenoiseLevel, so bugs do not always occur.

codecov-commenter commented 4 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #12   +/-   ##
========================================
  Coverage      2.21%   2.21%           
  Complexity      144     144           
========================================
  Files           163     163           
  Lines         17267   17267           
  Branches       2974    2974           
========================================
  Hits            383     383           
  Misses        16839   16839           
  Partials         45      45
Impacted Files Coverage Δ Complexity Δ
.../utokyo/rcast/karkinos/wavelet/WaveletDenoize.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a97dd83...5692d63. Read the comment docs.

xckitahara commented 4 years ago

Rebased to the master with tests added by another PR. And updated the test cases affected by this fix.