search

genomeannotation / GAG

Generates an NCBI .tbl file of annotations on a genome.
MIT License
64 stars 20 forks source link

incorrect positions created by fix_start_stop on - strand #170

Closed melisakman closed 7 years ago

melisakman commented 7 years ago

Running the fix_start_stop codons, I realized that start and stops are not created correctly for - strands. Start codon is printed from down stream CDS (the 2nd CDS with lower position values) and stop is from upstream (the first CDS with higher position). Thanks!

kylecannoles commented 7 years ago

Hi @melisakman, thanks for opening up an issue for this problem. I recently made a fix that I believe may address this issue here.

If you could test the build above with your data and report your results, it would be a great help to me.

The easiest way to use the latest dev build would be to click here. If that doesn't work, you can click the first link above and click on the green button labelled "Clone or Download" and then click on the "Download ZIP" link.

melisakman commented 7 years ago

Hi, I think the problem is fixed now. Thank you so much! Best, Melis

On Apr 4, 2017, at 11:33 AM, kylecannoles notifications@github.com wrote:

Hi @melisakman https://github.com/melisakman, thanks for opening up an issue for this problem. I recently made a fix that I believe may address this issue here https://github.com/genomeannotation/GAG/tree/dev.

If you could test the build above with your data and report your results, it would be a great help to me.

The easiest way to use the latest dev build would be to click here https://github.com/genomeannotation/GAG/archive/dev.zip. If that doesn't work, you can click the first link above and click on the green button labelled "Clone or Download" and then click on the "Download ZIP" link.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/genomeannotation/GAG/issues/170#issuecomment-291591868, or mute the thread https://github.com/notifications/unsubscribe-auth/AG9QNAvX0SoMagiMyWs6wymeK3tWA9X8ks5rsozsgaJpZM4Mx76F.

fbremer commented 7 years ago

Looks like this is fixed. Reopen if problem persists.