genomescan / gsport

3 stars 3 forks source link

Process.close() error when using python 3.6. #3

Closed JasperBoom closed 1 year ago

JasperBoom commented 3 years ago

Hello!

I was trying to run gsport to download data for one of our latest projects when I ran into this issues:

  File "/exports/sasc/jboom/miniconda3/envs/genomescan/bin/gsport", line 8, in <module>
    sys.exit(main())
  File "/exports/sasc/jboom/miniconda3/envs/genomescan/lib/python3.6/site-packages/gsport.py", line 455, in main
    download_all(session)
  File "/exports/sasc/jboom/miniconda3/envs/genomescan/lib/python3.6/site-packages/gsport.py", line 426, in download_all
    process.close()
AttributeError: 'Process' object has no attribute 'close'

I was able to solve this by upgrading my python version to 3.8. Colleagues of mine have also been able to use gsport without this specific issue using python 3.9.

The PyPI page suggests that python>=3.6 is supported, should that still be the case?

SergeWielhouwer commented 1 year ago

Thanks Jasper for describing this issue! The required Python version for gsport has been bumped up to version 3.7 in commit 362d1993dd897c1f8831adc38edfc7de0959eee2. This should resolve the missing attribute error for the Process object of the multiprocessing library. if this is not the case, please let us know by opening a new issue.

Source: https://docs.python.org/3/library/multiprocessing.html image