genomic-medicine-sweden / docker-sc2reporter

Dockerized version of the sc2reporter program.
GNU General Public License v2.0
0 stars 1 forks source link

Variant view #122

Closed moedarrah closed 10 months ago

moedarrah commented 1 year ago

What to show in the Variant View

Fattigman commented 1 year ago

Here is an image on what to show from the flask version:

Screenshot 2023-02-22 at 10 21 11
moedarrah commented 1 year ago

The variant endpoint is not working

talnor commented 1 year ago

This is the same issue as https://github.com/genomic-medicine-sweden/docker-sc2reporter/issues/29?

Fattigman commented 1 year ago

It is indeed, I will close it then because of duplication

Fattigman commented 10 months ago

We need to clarify

Fattigman commented 10 months ago

Codon change = Codons cDNA change = HGVSc Protein change = HGVSp

Fattigman commented 10 months ago

The last one is a bit more tricky. It looks like: External link CoVariant = https://covariants.org/variants/{ SYMBOL+':'+HGVSp} But it's constructed like:

It is parsed in the code like:

https://covariants.org/variants/{ covariants[v] }

covariants = {
        "S:A222V": "20A.EU1", "S:S477N": "20A.EU2", "S:N501Y": "S.N501", "S:E484K": "S.E484",
        "S:H69_V70del": "S.H69-", "S:N439K": "S.N439K", "S:Y453F": "S.Y453F", "S:S98F": "S.S98F",
        "S:L452R": "S.L452R", "S:D80Y": "S.D80Y", "S:A626S": "S.A626S", "S:V1122L": "S.V1122L",
        "S:Q677H": "S.Q677"
    }
var_show = v
if v == "S:H69_V70del":
        var_show = "S.H69-"

Here is the web site it uses https://covariants.org/variants if you want to investigate the how the urls are constructed. Maybe this should be done in the backend instead?

moedarrah commented 10 months ago

I agree it would be better to send it from the backend.

Fattigman commented 9 months ago

This is now done via backend at #162