Open Code0x58 opened 5 years ago
Merging #32 into master will decrease coverage by
0.53%
. The diff coverage is82.35%
.
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 99.81% 99.27% -0.54%
==========================================
Files 9 9
Lines 536 553 +17
==========================================
+ Hits 535 549 +14
- Misses 1 4 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/related/__init__.py | 100% <ø> (ø) |
:arrow_up: |
src/related/functions.py | 97.02% <82.35%> (-2.98%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7577a69...fb59c99. Read the comment docs.
Merging #32 into master will decrease coverage by
0.53%
. The diff coverage is82.35%
.
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 99.81% 99.27% -0.54%
==========================================
Files 9 9
Lines 536 553 +17
==========================================
+ Hits 535 549 +14
- Misses 1 4 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/related/__init__.py | 100% <ø> (ø) |
:arrow_up: |
src/related/functions.py | 97.02% <82.35%> (-2.98%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7577a69...15825ac. Read the comment docs.
I thought I'd quickly add TOML as an optional dependency to see how it fits in, as the interface is like the usual JSON+YAML load(s)/dump(s). It was easy to drop in TOML as a store for objects, but that's without any mapping to additional types in TOML.
Mapping to TOML types would be nice, as it could allow more generally craftable/ingestable toml files.
I'm thinking there are some options (in order of personal preference):
to_dict(…)
single dispatch methods to take something like afor_toml=True
kwarg which branches the handling. I'm not sure how this would tie in withto_model
other than making the relevant fields fields also handlerelated
at the momentAre there any maintainer/community thoughts on this?