Open dequis opened 4 years ago
Merging #43 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 9 9
Lines 538 538
=======================================
Hits 535 535
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/related/fields.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3799cde...ee0728a. Read the comment docs.
@imaurer hello! friendly reminder that this pull request exists!
Since attrs 19.2.0, the 'cmp' argument is deprecated and shows the following:
There was no processing of the argument other than passing it through, and the old default value (True) is equivalent to the current default of attrs (None, like cmp=True but without the warning)
This commit solves the problem by not passing cmp explicitly, but letting the user pass cmp (and get the deprecation warning, if they still rely on it and shouldn't) or pass the new arguments, eq and order.
So the behavior should remain the same, but deprecation warnings won't be raised by related, but by the users who actually pass an explicit True or False to cmp.