search

genophenoenvo / neon-datasets

Repository for code and derived data from NEON data products
MIT License
0 stars 4 forks source link

add code to download NOAA GEFS forecasts from EFI #33

Closed dlebauer closed 3 years ago

KristinaRiemer commented 3 years ago

I couldn't get the neon4cast package to install, so I cloned the repo and sourced the noaa functions.

Does it make the most sense to have this forecasted data be generated in its own script, or should it be included in the pre-existing curate_weather.R one? Also, is it easier to leave this forecasted data as its own csv, or could it be joined to the gcc data like the daymet data was?

KristinaRiemer commented 3 years ago

There's no date and time for each of the rows, but I think there should be? Are we supposed to generate that ourselves?

dlebauer commented 3 years ago

There's no date and time for each of the rows, but I think there should be? Are we supposed to generate that ourselves?

probably something like 

x <- noaa_fc %>% mutate(date = startDate + lubridate::hours(time))

Does it make the most sense to have this forecasted data be generated in its own script, or should it be included in the pre-existing curate_weather.R one?

Also, is it easier to leave this forecasted data as its own csv, or could it be joined to the gcc data like the daymet data was?

will defer to @DebasmitaPal1206, but future weather won't have gcc .. .it would be generated like gcc_pred <- predict(gcc_model, forecasts)

DebasmitaPal1206 commented 3 years ago

@KristinaRiemer Please keep forecasted weather data in a separate .csv fie. These forecasted weather parameters should be matched with the weather parameters in gcc_weather.csv file.

dlebauer commented 3 years ago

follow up in https://github.com/genophenoenvo/neon-datasets/issues/37