Error when using `main` as master-branch

genotrance / nimgen

Nimgen is a helper for c2nim to simplify and automate the wrapping of C libraries

MIT License

114 stars 11 forks source link

Error when using `main` as master-branch #49

Open ThomasTJdev opened 3 years ago

ThomasTJdev commented 3 years ago

Currently the branch master is hardcoded, but with recent changes to Github we now see people using the name main instead. This is a problem for my library https://github.com/ThomasTJdev/nimlibxlsxwriter/issues/1.

The hardcoded master is located here. https://github.com/genotrance/nimgen/blob/7662523501b00f35dcaab1af50481a3bacfce5f1/src/nimgen/external.nim#L82-L90

joshgoebel commented 3 years ago

Also running into this exact problem and thinking perhaps this should be configurable?

ThomasTJdev commented 3 years ago

Hi @joshgoebel

My PR https://github.com/genotrance/nimgen/pull/50 fixes this and allows for custom branch-naming.

But as stated in the nimgen README it has been deprecated..

Nimgen has been superseded by nimterop. Existing wrappers are slowly being migrated over to nimterop. No new features will be implemented going forward.

genotrance commented 3 years ago

Arguably, nimterop is also dead since I'm no longer maintaining either project. Considering c2nim is still being actively developed, I'm open to PRs and owners for nimgen. Somehow I didn't get a notification for the PR, just merged.