search

genouest / biomaj-daemon

micro service to manage biomaj client requests and bank updates
0 stars 3 forks source link

Log dir not remove with `--remove-all` and not proxy #2

Closed horkko closed 7 years ago

horkko commented 7 years ago

Hi,

I've noticed a new behavior with micro services architecture, in particular when I want to completely remove a bank using --remove-all option. In my case, I only use micro service architecture for download, I do not used a proxy at all. So when I want to remove a bank, the bank log directory is not removed, because of this and then of that Is there a good reason for that?

Thanks

Emmanuel

osallou commented 7 years ago

In non proxy, all actions show current action log, not always in proxy mode. Will modify non proxy case to deactivate logs in remove all action

Le mer. 22 févr. 2017 11:15, Emmanuel Quevillon notifications@github.com a écrit :

Hi,

I've noticed a new behavior with micro services architecture, in particular when I want to completely remove a bank using --remove-all option. In my case, I only use micro service architecture for download, I do not used a proxy at all. So when I want to remove a bank, the bank log directory is not removed, because of this https://github.com/genouest/biomaj-daemon/blob/55a0ae86410f649721c6dac12d836510865fee30/biomaj_daemon/daemon/utils.py#L472 and then of that https://github.com/genouest/biomaj/blob/1bd2d1aed298a39c9ca247814a2685605e7ca89a/biomaj/bank.py#L928 Is there a good reason for that?

Thanks

Emmanuel

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/genouest/biomaj-daemon/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-gYsSBLVWaf63YQuyXHtKo22uYDz0mks5rfAqlgaJpZM4MIcn2 .