search

genouest / biomaj-download

Download microservice for BioMAJ
GNU Affero General Public License v3.0
1 stars 7 forks source link

Add a protocol option to set CURLOPT_FTP_FILEMETHOD #18

Closed duboism closed 4 years ago

duboism commented 4 years ago

This PR allows to pass an option to CurlDownloader to set CURLOPT_FTP_FILEMETHOD. Some values (nocwd and singlecwd) allow to significantly speed up the download but are not always supported. Both are supported on NCBI's ftp server for instance.

The values to use are the ones valid for the corresponding CLI option (--ftp-method) plus default.

AFAIU we don't need to modify other packages to support that in banks.

osallou commented 4 years ago

You should add to readme info on additional ftp options

duboism commented 4 years ago

If I'm correct, protocol options are not mentioned anywhere in the doc and I'm not sure that a few lines in README.md is enough. Maybe we should do an effort to update the doc.

osallou commented 4 years ago

in global.properties.example of biomaj there are some examples (in options, with tcp_keepalive etc.)

Maybe download should specify in its README some protocol specific options to be set in global (if needed)

duboism commented 4 years ago

We have updated README.md. We wanted to use a table but it proved hard so we used a list.