search

genouest / biomaj-download

Download microservice for BioMAJ
GNU Affero General Public License v3.0
1 stars 7 forks source link

Allow redirections #35

Closed duboism closed 4 years ago

duboism commented 4 years ago

This PR addresses #33 by introducing an option to allow redirections (they can be disabled).

The implementation is rather simple but the PR is a bit large because we added some notes about options, cleaned some files, etc.

duboism commented 4 years ago

I converted the PR to draft and removed "[WIP]" from the title.

duboism commented 4 years ago

As discussed, we don't want to rely on Biomajconfig.DEFAULTS for initialization so 38c0bfe removes it.

duboism commented 4 years ago

Updated CHANGES.txt and removed draft status.

duboism commented 4 years ago

Just added some notes about the version in which some options were introduced.

duboism commented 4 years ago

Switched back to draft because I forgot to log information about redirections (which will allow better tests).

osallou commented 4 years ago

looks fine for me, ready for merge?

duboism commented 4 years ago

Ready for merge. Thanks in advance.