genouest / biomaj-download

Download microservice for BioMAJ
GNU Affero General Public License v3.0
1 stars 7 forks source link

Correct PR #30 #37

Closed duboism closed 4 years ago

duboism commented 4 years ago

This PR addresses some errors introduced by #30. There are 2 classes of errors.

First, direct downloaders were broken and I missed that:

Next, tests in PR #30 were flawed and therefore some errors were not detected. The main errors here are:

Last but not least, IRODSDownload was not updated.

Status:

osallou commented 4 years ago

405 error code is returned in test, but i do not know if this is always the case with all servers. Maybe should be tested with a local python flask app for example to be sure

osallou commented 4 years ago

Comment on my comment, after thinking about previous other tests, if head is not supported, yes 405 will be raised, and we should just continue in this case. In case of other errors, ok to raise exception