search

genouest / biomaj-download

Download microservice for BioMAJ
GNU Affero General Public License v3.0
1 stars 7 forks source link

Allow to use hardlinks in LocalDownload. #5

Closed lburlot closed 5 years ago

lburlot commented 5 years ago

This PR is a follow-up to genouest/biomaj-core#2 to allow LocalDownload to use hardlinks. By default, hardlinks are disabled so everything is backward-compatible.

duboism commented 5 years ago

Arf, sorry for the too early PR. We will correct the problems.

osallou commented 5 years ago

Pb is biomaj core has not yet published as package (only merged), so last modifications are not installed. I need to fix this to upload core to pypi. I expect to do that next week

lburlot commented 5 years ago

Pb is biomaj core has not yet published as package (only merged), so last modifications are not installed. I need to fix this to upload core to pypi. I expect to do that next week

Yep, we realized that. There was also a minor issue for python2. Lets wait for the publication of biomaj-core 3.0.18.

osallou commented 5 years ago

@lburlot merged and biomaj-core tagged at 3.0.18, I will update requirements.txt to force use of core min version 3.0.18

duboism commented 5 years ago

@osallou Thanks a lot for the merge and the new package. We still have a PR to do on biomaj itself.

osallou commented 5 years ago

@duboism Just be sure to resync with master for futher pull requests with a new branch for each