Correct weird construct in test.

genouest / biomaj-download

Download microservice for BioMAJ

GNU Affero General Public License v3.0

1 stars 7 forks source link

Correct weird construct in test. #6

Closed duboism closed 5 years ago

duboism commented 5 years ago

The test in TestBiomajFTPDownload.test_download fails if no exception is raised when calling ftpd.download which doesn't seem correct (this was introduced in 83697701c5024d6bc1a228e62140fe8369c809cb but doesn't seem related).

This PR simplify the test (which passes most of the time).

osallou commented 5 years ago

The problem is 'most of the time' I think that this test should accept pass AND failure with a log in cas of failure. I think failure is related to remote site

duboism commented 5 years ago

This test (and others) pass under normal conditions and when it fails the message usually clearly indicates that the problems comes from the network or the remote site. Also this test is disabled for CI so it won't impact that. But if you insist, we can implement it the way you describe it.

osallou commented 5 years ago

I did not remember it was disabled for ci so should be ok

duboism commented 5 years ago

Thanks for merging !