search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
704 stars 190 forks source link

Character data should include their id #110

Closed thomas-tcj closed 3 months ago

thomas-tcj commented 2 years ago

Hey, I think it would be useful for the character data to include the identifier of the character.

This way, when parsing data from https://api.genshin.dev/characters/all, it would be possible to determine the URL for the icon of each character.

Happy to do it myself, if we can agree that this is a useful feature.

TheMaskedPony commented 2 years ago

I agree, it's very hard to identify characters. For example, vision is added to name for Traveler and others are identified by their name. In my opinion, Ids should be artificial and given in data. Anyway it would be very useful to include ids.

LolnationCH commented 2 years ago

I think it would be great, I had to make my own json file, and then I merged the two of them together. Here it is if anyone want to use it (Had to put .md cause github don't want .json...) CharactersId.json.md

xannem commented 1 year ago

Also agree identifiers would be helpful, created PR with the ids: https://github.com/genshindev/api/pull/220