search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
704 stars 190 forks source link

Fixed icon centering issues #120

Closed thomas-tcj closed 2 years ago

thomas-tcj commented 2 years ago

Hey, I'd like to propose two changes to the character icons.

Yanfei's small icon was a scaled down version of her big icon, instead of the usual cut-off that was done for the other characters. I changed the icon to be more inline with the rest: (old/new) yanfei change

Bennett's large icon was off-center to the right, due to the bandana thing on his arm. I slightly moved him to the left so that his eyes are in the center of the icon, like the other characters. (old/new) bennett change

Note that I wasn't able to build the project due to some typescript compilation errors (that I suppose are present on the master branch?), so I wasn't able to verify my changes. I expect no problems though, given the triviality of the PR.

NurMarvin commented 2 years ago

Yes, the TypeScript errors will be addressed soon, but since you just changed assets there shouldn't be any issues with something breaking.