search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
704 stars 190 forks source link

Character skins #122

Closed MartiiDev closed 3 months ago

MartiiDev commented 2 years ago

Hey, your API seems nice but I thought about a little addition. I think it would be nice for each character to have a list of their skins (if they have some) when you request the character's info:

Example for Keqing (since she will have a skin in 2.4) "skins":[{"name":"Opulent Splendor","image":"https://skin_img.png"},

Tainted06 commented 2 years ago

Great idea, I'll work on adding it right now. I'll add information about the name, description, rarity, and price. For the image, I'll add it how the other images are and name it outfit-outfitname. I'll also add the image name in the json data just to make it easier.

man90es commented 3 months ago

Looks like at least some outfits have been added to the data files. It there are any specific outfits still missing, please make a separate issue and/or PR