genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
702 stars 196 forks source link

Update entities to have an ID field #266

Closed SteeledSlagle13 closed 4 months ago

SteeledSlagle13 commented 7 months ago

Add id fields to all entities Field maps to the directory name. This makes it easier to reference image folders if consumers are just using the GET :type/all endpoint. (some entities already had an id field mapping to their directory... this just adds it to all other entities)

man90es commented 4 months ago

I kinda need this feature too, so I'm going to start working on my own version next week if there's no activity from @SteeledSlagle13 until then

M4GICB commented 4 months ago

@man90es and @SteeledSlagle13 - is this fixed now with pr https://github.com/genshindev/api/pull/279 ?

man90es commented 4 months ago

@man90es and @SteeledSlagle13 - is this fixed now with pr #279 ?

Yeah we can close this one unless that blackcliff-agate/en.json change is any valuable. My browser freezes when I try to check what that change is

M4GICB commented 4 months ago

I was able to check. The blackcliff-agate/en.json change is just adding the id field and all the other changes in the file seem like linter changes.