search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
691 stars 187 forks source link

FIX #281 Inconsistency in case types( camelCase and snake_case) in characters api #282

Open Thiru-kumaran-R opened 1 month ago

Thiru-kumaran-R commented 1 month ago

FIX #281 ,resolved inconsistency issue in casing in all json file in characters including 'add_type_to_character.js' and 'add_weapon_type.js'

man90es commented 1 month ago

I don't think it's a good idea to change attributes that someone's app may already depend on. If anything, I'd delete those attributes completely (still a bad idea) because they are duplicates of "vision" and "weapon"