genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
710 stars 197 forks source link

Multiple things #34

Closed liz3 closed 3 years ago

liz3 commented 3 years ago

This PR does a bunch of things, broken down:

I might look into ways of maybe streamlining this and extract data from the game assets to make it a ton easier and not require manual addition and provide support for all languages.

NurMarvin commented 3 years ago

Thanks for the PR, especially the additions of the types. We also already tried to get the data from the game assets before, but we aren't really that great at data mining or reverse engineering so we sadly never found anything relevant, but I hope you will have better luck with it than us because this would be a huge breakthrough for the API.