search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
702 stars 193 forks source link

Weapon base ATK cast to strings #40

Closed apex2504 closed 3 years ago

apex2504 commented 3 years ago

I noticed that the "baseAttack" for weapons are cast to strings rather than integers/numbers/whatever. Is this intentional, or would ints/numbers be a more appropriate type for these?

NurMarvin commented 3 years ago

Probably unintended, since that data was gathered through scraping and number strings weren't transformed to numbers. Will fix this in a bit.

NurMarvin commented 3 years ago

Closed via 8cb7754c93efe04c19821896c99c129c0d1b46f9