search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
710 stars 197 forks source link

Added parts of german translation for food. #56

Closed arktn closed 3 years ago

arktn commented 3 years ago

Again I tried adding as much as I could but sadly I don't have all the food and I couldn't find all the information about it online.

arktn commented 3 years ago

Sounds like a pretty good idea to me but we gotta see what the repo-owners think about that. I would personally prefer it that way, it would make translation a lot better and faster.

arktn commented 3 years ago

Are we gonna do it this way now or no? Just asking because if so I can start working on the rest of the translation.

NurMarvin commented 3 years ago

should we takle out the english versions from the german translation and in code default to english if a field doesn't exist in other languages maybe?

Pretty sure that's how I did it before. Might have been lost when you re-did the API. Would love to make it that way again, so I'll be removing the unchanged translations from this PR and then merge it but for now I will merge this PR and then once the functionality is back I will clean up the dataset.

arktn commented 3 years ago

Perfect, I'll just remove the english parts the next time I add more translations to this.