search

genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
702 stars 193 forks source link

Added german translations. #57

Closed arktn closed 3 years ago

arktn commented 3 years ago

I didn't have that much time so I added some some easy translations and one big translation. I have a question tough, since many of the named sources in the cooking ingredients are "custom made" (meaning there's no official translation) should I just create "custom" translations in German?

NurMarvin commented 3 years ago

Yeah, in that case custom translations are probably the best approach. In that case you should however try to use the same translations the game would use for certain words. E.g. if the game uses the translation Resourcen for the English word materials, you should also use that word in your translations instead of something else with a similar or the same meaning, like Materalien (this is a completely made up example, I don't know what translations the game uses). And thanks for the PR!

arktn commented 3 years ago

Okay, I'll do so in the next pull request.