Certain weapons have incorrect "location" field

genshindev / api

A fan-made Genshin Impact API for easy access to game data.

https://genshin.jmp.blue

Open Software License 3.0

710 stars 197 forks source link

Closed aamiaa closed 3 years ago

aamiaa commented 3 years ago

The following weapons have their location set to Gacha despite not being obtainable from it, but rather from chests or npcs:

Amber Catalyst
Dark Iron Sword
Ebony Bow
Fillet Blade
Halberd
Otherworldly Story
Quartz
Skyrider Greatsword
Twin Nephrite
White Iron Greatsword

Also Kunwu's Iris Rift needs to be renamed to Vortex Vanquisher

arktn commented 3 years ago

I checked over it and yeah you're right. I fixed these mistakes and will open a pullrequest now!

JMPJNS commented 3 years ago

can we close this issue?