genshindev / api

A fan-made Genshin Impact API for easy access to game data.
https://genshin.jmp.blue
Open Software License 3.0
704 stars 190 forks source link

A lack of information for /characters endpoint #94

Closed CuteShaun closed 2 years ago

CuteShaun commented 2 years ago

Guys, thanks for doing a great job! When I getting data from https://api.genshin.dev/characters, there are only characters' names, and what if somebody wants to make some filters or sorts by characters (elements, nation, rarity), etc. It seems we need an array of objects with all info about every character in general /characters request, not only in special like /characters/albedo

NurMarvin commented 2 years ago

That's already a thing! It's a bit hidden, I gotta admit, but there's an /all endpoint for all entity types, which also supports filtering. If you for example want all characters from Mondstadt, you can just use /characters/all?nation=Mondstadt. If you don't want any filtering, just use /characters/all without any query parameters.

CuteShaun commented 2 years ago

Thanks a bunch, I hope we can add this info in documentation later :)