genshinsim / gcsim.app

gcsim website
MIT License
2 stars 21 forks source link

Add implementation of internationalization(i18n) and localization of Chinese. #27

Closed Titvt closed 2 years ago

Titvt commented 2 years ago

This tool is amazing and so many Chinese like it, so I decide to translate it to Chinese. And I wish it will support more and more languages, thus I add i18n for it. (Although I have done a lot of testing, there may still be potential bugs.)

srliao commented 2 years ago

@Titvt I'm so sorry I didn't see this PR at all! Will review and get it added asap. Was thinking of doing it myself at some point.

srliao commented 2 years ago

@Titvt we have incorporated your commit into this branch here: https://github.com/genshinsim/gcsim.app/tree/goodImportAndi18n

This branch will be merged into main as soon as we're done testing it for bugs. Had to do it this way because there was quite a bit of conflicts with the GOOD import...

Thank you very much for doing this!! If you didn't this would not have happened this quickly