genshinsim / gcsim.app

gcsim website
MIT License
2 stars 21 forks source link

Expired mods/status are not being handled correctly #52

Closed shizukayuki closed 2 years ago

shizukayuki commented 2 years ago

Seems to work just fine expect when there is many mods/status getting added/refreshed, which is the case for almost all configs.

config: 5q4V1rJVWkFXeZJbwUYD_

Current Behavior

some expired lines are going under frame -1.
clicking on sucrose-c6 tracks the last mod event at frame 5570 | 92.83s.

image

this is the main bug. where for some reason expired lines are missing. the expired line should be at frame 877 | 14.62s

image

Expected Behavior

minor but the expired line should be formatted as x mod expired [f | time] where f is the mod added event. so something like raiden-e mod expired [1636 | 27.27s] for the following screenshot.

image